epics-base7: 7.0.8 -> 7.0.8.1 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait does this break epics3? Probably tbh, should add a version check to disable fortifysource if version < 7.0.8.1 |
|
Ha, I haven't tested the fortify issue with epics-base v3, so I'm not sure if it's affected or not. To be fair, I don't think anyone from our team uses epics-base v3 nowadays, so yeah… I'll run the checks, and merge if they all pass. Thanks! |
minijackson
added
the
backport nixos-23.11
|
So, after running the tests, the fortify issue is not resolved yet, and still causes issues. The pull request fixing the issue isn't merged yet, but they added a logic to limit the build to I think we'll need to still disable |
Synthetica9
force-pushed
the
epics-7.0.8.1
branch
from
a10ea76
to
39655aa
Compare
|
Okay re-enabled but kept the updated comment |
minijackson
approved these changes
Jul 18, 2024
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most relevant for this project: the fortify-source issue was worked around, will probably be fixed in the next minor version.
Do we want to keep in the fortify3 disable for backwards source compatibility or remove it for forwards compatibility?